asynchronously resolve a name to multiple address objects #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 91.15% (diff: 100%)@@ trunk #548 diff @@
==========================================
Files 834 836 +2
Lines 145653 145992 +339
Methods 0 0
Messages 0 0
Branches 12913 12930 +17
==========================================
+ Hits 132735 133080 +345
+ Misses 10664 10660 -4
+ Partials 2254 2252 -2
|
and hey, what do you know, it's dead code that's unnecessary.
|
I am bumping into this issue twisted/twistedchecker#44 while writing the docstrings for this. |
acquiesce to the vagaries of reactor startup
hawkowl
approved these changes
Nov 26, 2016
|
|
||
| from __future__ import division, absolute_import | ||
|
|
||
| __metaclass__ = type |
There was a problem hiding this comment.
To avoid accidentally declaring an old-style class.
| @return: The resolution in progress. | ||
| @rtype: L{IResolutionReceiver} | ||
| """ | ||
|
|
There was a problem hiding this comment.
this seems like too many newlines
|
|
||
| from __future__ import division, absolute_import | ||
|
|
||
| __metaclass__ = type |
There was a problem hiding this comment.
Same as above. It avoids accidentally declaring an old-style class in py2.
|
Why not add it to the list in t.test.test_nooldstyle or whatever?
…On 26 Nov 2016 18:09, "Glyph" ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/twisted/internet/test/test_resolver.py
<#548>:
> @@ -0,0 +1,559 @@
+# Copyright (c) Twisted Matrix Laboratories.
+# See LICENSE for details.
+
+"""
+Tests for implementations of L{IHostnameResolver} and their interactions with
+reactor implementations.
+"""
+
+from __future__ import division, absolute_import
+
+__metaclass__ = type
Same as above. It avoids accidentally declaring an old-style class in py2.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#548>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADJ2XDT1hbFQE0CfjZ_309Dj_07-kAS8ks5rB9sugaJpZM4KDvyY>
.
|
It's kind of a separate issue. Although that would also be a good thing. This list in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://twistedmatrix.com/trac/ticket/4362